Conversation
iarspider
commented
Dec 29, 2019
iarspider
commented
- Non-interactive mode for spack checksum (checksum all passed versions)
- Allow passing 'package@version' to spack checksum
…on' to spack checksum
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
Completely agree with these changes. One other thing I think you could add: if I pass a list of versions to checksum, we should automatically checksum those versions without asking how many of them to checksum.
Fix typo
|
I will add the second part ("if I pass a list of versions to checksum") a bit later. |
|
Another feature that would be cool is the ability to do: $ spack checksum [email protected],1.2.4,1.2.5
$ spack checksum [email protected]:1.2.5and have it download all 3 versions. But I have no idea how difficult this would be to integrate. |
This behaviour is explicitly forbidden in the code: https://github.com/spack/spack/blob/develop/lib/spack/spack/cmd/checksum.py#L50 . Do you think it's ok to change it? |
|
@adamjstewart can this be merged? |
Co-Authored-By: Adam J. Stewart <[email protected]>
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
This looks good to me, but I'll let one more maintainer review before merging.
|
Can you run |
|
@iarspider There are |
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
I left a couple of comments/questions. Let me know if something is not clear or if you disagree with them.
Co-Authored-By: Adam J. Stewart <[email protected]>
|
Ping @alalazo |
|
Ping ping @alalazo |
|
Ping ping ping @alalazo |
Use batch mode when adding a new package
|
Ping x4 @alalazo |
4 participants
