Gnupg2 Homebrew install on macOS provides gpg command not gpg2.#14236
Closed
gartung wants to merge 4 commits intospack:developfrom
Closed
Gnupg2 Homebrew install on macOS provides gpg command not gpg2.#14236gartung wants to merge 4 commits intospack:developfrom
gartung wants to merge 4 commits intospack:developfrom
Conversation
gartung
force-pushed
the
gartung-gpg-macos
branch
from
54d0486 to
8b0b5f0
Compare
Member
|
You could do something like we do for Python where we search for |
gartung
force-pushed
the
gartung-gpg-macos
branch
from
8b0b5f0 to
9a7e897
Compare
adamjstewart
requested changes
Jan 31, 2020
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
I think the following change is the simplest way to do things.
Co-Authored-By: Adam J. Stewart <[email protected]>
lib/spack/spack/util/gpg.py
Outdated
| # SPDX-License-Identifier: (Apache-2.0 OR MIT) | ||
|
|
||
| import os | ||
| import platform |
Member
There was a problem hiding this comment.
I think this import can be removed to
Member
Author
|
After merging with develop there are no changes. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Homebrew to install gnupg2 on macOS provides symbolic link /usr/local/bin/gpg but not /usr/local/bin/gpg2. On macOS check for gpg in addition to gpg2.
This might break test where keys are created because gnupg has a limit on the length of the path to the keystore. It may require running
on macOS