Mirrors: add option to exclude packages from "mirror create"#14154
Merged
becker33 merged 11 commits intospack:developfrom Jun 4, 2020
Merged
Mirrors: add option to exclude packages from "mirror create"#14154becker33 merged 11 commits intospack:developfrom
becker33 merged 11 commits intospack:developfrom
Conversation
…user to specify a file of specs to exclude when creating a mirror. this is anticipated to be useful especially when using the '--all' option
This comment has been minimized.
This comment has been minimized.
becker33
reviewed
May 29, 2020
Member
becker33
left a comment
There was a problem hiding this comment.
Mostly LGTM. One API request
…ld be excluded on the command line
becker33
approved these changes
Jun 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #13604
See: #13925
Add an --exclude-file option to 'spack mirror create' which allows a user to specify a file of specs to exclude when creating a mirror. this is anticipated to be useful especially when using the '--all' option.
The option can be used as follows:
Where the exclude file looks like
#13604 points out there are cases where
spack mirror create --allstalls because of packages that require interaction or otherwise hang. #13881 adds a connection timeout for URL fetchers, which handles a subset of these cases.#13925 adds a universal process timeout that is available for all fetch actions, which is intended as a catch-all solution, but requires additional work and special-case handling of git resources (which are the most common non-URL resources).This also adds a file toshare/spack/cmd-config/mirror-exclude-specs.txtThis file is added because it is anticipated that users will commonly need to filter the same set of packages. This is not added as config because modifying the mirror configuration to support blacklisting would require significant adjustments, and also because this option should only be required while #13925 is incomplete.New updates (as of May 28):
--dependencies--versions-per-specwhen using the--alloption. For examplespack mirror create --all --versions-per-spec 1would download the latest version of every package.