FIX: Making berkeley-db package fetch from correct links#14147
Merged
adamjstewart merged 4 commits intospack:developfrom Dec 13, 2019
Merged
FIX: Making berkeley-db package fetch from correct links#14147adamjstewart merged 4 commits intospack:developfrom
adamjstewart merged 4 commits intospack:developfrom
Conversation
Contributor
Author
|
(please disable codecov on this PR, all other tests pass) |
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
I think it's fine to have older versions not available for download. Can you sort the versions from newest to oldest? Also, in regards to codecov, see the note at the bottom of https://spack.readthedocs.io/en/latest/contribution_guide.html#coverage
Contributor
Author
|
Ok I integrated your proposed changes and reordered the versions. |
adamjstewart
approved these changes
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The berkeley-db package normally fetches from the Gentoo repository because the Oracle website requires login. However the archives seem to have been removed from the Gentoo repository.
This PR comments the
url_for_versionfunction so that it reverts to downloading from Oracle. This will work for version 6.2.32 (the latest in this package) and 6.1.29, but not for older ones.If anyone knows of another mirror from which more versions of BerkeleyDB can be downloaded, please update the package. At least with this PR the two latest versions are available again.
Fixes #14145