doxygen: Fix libiconv checks#14106
Merged
adamjstewart merged 1 commit intospack:developfrom Dec 11, 2019
Merged
Conversation
PR spack#10589 introduced a libiconv dependency to doxygen. This causes problems on Linux systems, since the iconv symbols are included in libc, which causes CMake to use the external header but not the external library. Work around this by always using the external libiconv.
adamjstewart
approved these changes
Dec 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #10589 introduced a libiconv dependency to doxygen. This causes problems on Linux systems, since the iconv symbols are included in libc, which causes CMake to use the external header but not the external library. Work around this by always using the external libiconv.