Add "same_version_as"-directive to fix py-protobuf dependencies#14002
Open
obreitwi wants to merge 2 commits intospack:developfrom
Open
Add "same_version_as"-directive to fix py-protobuf dependencies#14002obreitwi wants to merge 2 commits intospack:developfrom
obreitwi wants to merge 2 commits intospack:developfrom
Conversation
Member
|
This looks really useful! |
Member
|
For the record, I'm also modifying the |
obreitwi
force-pushed
the
pr/add_same_version_as_directive_fix_protobuf
branch
from
d7ec118 to
66cd9d9
Compare
Member
Author
|
Ah yes, I am eagerly waiting for tensorflow to build again. Crossing all
available fingers!
…On Thu, Dec 5, 2019 at 9:02 PM Adam J. Stewart ***@***.***> wrote:
For the record, I'm also modifying the py-protobuf package in #13112
<#13112>, expected to be merged today.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14002?email_source=notifications&email_token=AAA6CBFFNXONYSUIDZLUPL3QXFM4ZA5CNFSM4JV5U3R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGB6X5I#issuecomment-562293749>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6CBGJWNX4UR247FX43SDQXFM4ZANCNFSM4JV5U3RQ>
.
|
obreitwi
force-pushed
the
pr/add_same_version_as_directive_fix_protobuf
branch
2 times, most recently
from
552b481 to
fc47a1d
Compare
Member
Author
|
Since #13112 is now merged, I rebased accordingly. |
Member
Author
|
Is there anything preventing this from getting merged? |
Member
|
Relates to #10255 |
obreitwi
force-pushed
the
pr/add_same_version_as_directive_fix_protobuf
branch
2 times, most recently
from
1477dd5 to
b6c16b7
Compare
obreitwi
force-pushed
the
pr/add_same_version_as_directive_fix_protobuf
branch
from
b6c16b7 to
e71f3e4
Compare
Member
Author
|
Rebased again! Let me know if anything is still missing… |
Leave out release candidates. Change-Id: Iac99fdab05d9b2760d87805b3e1398c5d6516ec4
obreitwi
force-pushed
the
pr/add_same_version_as_directive_fix_protobuf
branch
from
e71f3e4 to
68cc955
Compare
Problem: Each version of `py-protobuf` depends on the exact same version of `protobuf`. Tracking this kind of dependency is only possible with a lot of boilerplate, which we aim to avoid. Solution: * Add `same_version_as`-directive that automatically adds a one-to-one dependency of each version of the package to the exact same version of the other package. * Use `same_version_as`-directive to keep versions of py-protobuf and protobuf in sync (i.e., `[email protected]` depends on `[email protected]`, `[email protected]` depends on `[email protected]` and so forth). * Add mock packages used in tests to ensure `same_version_as`-directive remains functional. Change-Id: I3f28d76cb32a0a91e38c5c70fb650698ab7f0316
obreitwi
force-pushed
the
pr/add_same_version_as_directive_fix_protobuf
branch
from
68cc955 to
2002f3b
Compare
Member
|
I would love to see this PR revived. Would it be less controversial if we add a new parameter to |
Member
|
@alalazo how hard would this be with the new concretizer? Can we add a |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Each version of
py-protobufdepends on the exact same version ofprotobuf. Tracking this kind of dependency is only possible with a lot of boilerplate, which we aim to avoid.Solution:
Add
same_version_as-directive that automatically adds a one-to-one dependency of each version of the package to the exact same version of the other package.Use
same_version_as-directive to keep versions of py-protobuf and protobuf in sync (i.e.,[email protected]depends on[email protected],[email protected]depends on[email protected]and so forth).Add mock packages used in tests to ensure
same_version_as-directive remains functional.