Patching: do strict version range checking#13989
Conversation
…rectly treat a version range constraint as satisfied when mixing x.y and x.y.z versions
|
I tested this and I agree this fixes the problem I reported in #13961. I also agree this is only a problem for So, this fixes the case of how to interpret a short name in a spec, as Intel-tbb has versions 2019, 2019.1, 2019.2, etc. How do I write I can't use In this case, there is a workaround: Basically, I don't see a way to tell But that's really a problem for #8957. Don't let it delay committing Thanks! |
Recent commit e9ee9ea (spack#13989) fixed testing version ranges inside patch when clauses. Previously, it was necessary to write all revs individually for packages with multiple length version numbers (2019 and 2019.1). This fixes the build for the old 2017.* versions.
Fixes #13961
Apply strict constraint checks for patches, otherwise Spack may incorrectly treat a version range constraint as satisfied when mixing x.y and x.y.z versions.
See also: #8957 (comment)