amber: Improved package.py and added version 18#13945
Merged
adamjstewart merged 13 commits intospack:developfrom Dec 2, 2019
hseara:amber
Merged
amber: Improved package.py and added version 18#13945adamjstewart merged 13 commits intospack:developfrom hseara:amber
adamjstewart merged 13 commits intospack:developfrom
hseara:amber
Conversation
Contributor
hseara
commented
Dec 1, 2019
hseara
commented
- Added amber 18 with ambertools 19
- Added all available patches
- Added +update variant to use the self update
- Added +openmp variant to get openmp optomizations
- Added +x11 variant when possible
- Splitted amber 16 and 18 dependencies
- We now detect the copiler type and compile accordingly
- Added cray variant which is a bit special (untested)
- Improved detection of possible cuda versions
- All compilation optimizations +mpi +openmp +cuda are compatible
- Updated to use setup_build_environment(), setup_run_environment()
- Added amber 18 with ambertools 19 - Added all available patches - Added +update variant to use the self update - Added +openmp variant to get openmp optomizations - Added +x11 variant when possible - Splitted amber 16 and 18 dependencies - We now detect the copiler type and compile accordingly - Added cray variant which is a bit special (untested) - Improved detection of possible cuda versions - All compilation optimizations +mpi +openmp +cuda are compatible - Updated to use setup_build_environment(), setup_run_environment()
) * dealii: Added 'threads' variant that controls the DEAL_II_WITH_THREADS cmake option and the dependency on Intel TBB * Update var/spack/repos/builtin/packages/dealii/package.py Co-Authored-By: Adam J. Stewart <[email protected]>
Member
I recently merged a PR that does this for every package in Spack, so you'll need to rebase/resolve merge conflicts. |
- Added amber 18 with ambertools 19 - Added all available patches - Added +update variant to use the self update - Added +openmp variant to get openmp optomizations - Added +x11 variant when possible - Splitted amber 16 and 18 dependencies - We now detect the copiler type and compile accordingly - Added cray variant which is a bit special (untested) - Improved detection of possible cuda versions - All compilation optimizations +mpi +openmp +cuda are compatible - Updated to use setup_build_environment(), setup_run_environment()
Contributor
Author
|
Please do not merge yet. I am still adding some missing dependencies. |
Member
|
The |
Contributor
Author
|
I am done from my side. Unless there is more job you need from my side, feel free to merge. |
adamjstewart
requested changes
Dec 2, 2019
- Added amber 18 with ambertools 19 - Added all available patches - Added +update variant to use the self update - Added +openmp variant to get openmp optomizations - Added +x11 variant when possible - Splitted amber 16 and 18 dependencies - We now detect the copiler type and compile accordingly - Added cray variant which is a bit special (untested) - Improved detection of possible cuda versions - All compilation optimizations +mpi +openmp +cuda are compatible - Updated to use setup_build_environment(), setup_run_environment()
Contributor
Author
|
I am not sure how dealii ended up in my pull request. It was certainly not my intent. Anyway, I fixed some flake8 problems with dealii, that were making my checks to fail. Please let me know if the package is not ready for merging. |
adamjstewart
reviewed
Dec 2, 2019
adamjstewart
approved these changes
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.