dealii: Added 'threads' variant that controls the TBB dependency#13931
Merged
adamjstewart merged 2 commits intospack:developfrom Dec 1, 2019
Merged
Conversation
alexrobomind
force-pushed
the
spack_threads_flag_in_dealii_package
branch
from
1015ede to
5621484
Compare
…S cmake option and the dependency on Intel TBB
alexrobomind
force-pushed
the
spack_threads_flag_in_dealii_package
branch
from
5621484 to
6757b70
Compare
Co-Authored-By: Adam J. Stewart <[email protected]>
Contributor
Author
|
The coverage change report seems a bit strange to me, especially given that the default value is to behave as before. What is going on there? |
davydden
approved these changes
Dec 1, 2019
Member
See the note at the bottom of https://spack.readthedocs.io/en/latest/contribution_guide.html#coverage. In this case, the reason coverage dropped so much is because we run macOS tests on develop but not on PRs. |
adamjstewart
pushed a commit
that referenced
this pull request
Dec 2, 2019
* amber: Improved package.py and added version 18 - Added amber 18 with ambertools 19 - Added all available patches - Added +update variant to use the self update - Added +openmp variant to get openmp optomizations - Added +x11 variant when possible - Splitted amber 16 and 18 dependencies - We now detect the copiler type and compile accordingly - Added cray variant which is a bit special (untested) - Improved detection of possible cuda versions - All compilation optimizations +mpi +openmp +cuda are compatible - Updated to use setup_build_environment(), setup_run_environment() * dealii: Added 'threads' variant that controls the TBB dependency (#13931) * dealii: Added 'threads' variant that controls the DEAL_II_WITH_THREADS cmake option and the dependency on Intel TBB * Update var/spack/repos/builtin/packages/dealii/package.py Co-Authored-By: Adam J. Stewart <[email protected]> * amber: Improved package.py and added version 18 - Added amber 18 with ambertools 19 - Added all available patches - Added +update variant to use the self update - Added +openmp variant to get openmp optomizations - Added +x11 variant when possible - Splitted amber 16 and 18 dependencies - We now detect the copiler type and compile accordingly - Added cray variant which is a bit special (untested) - Improved detection of possible cuda versions - All compilation optimizations +mpi +openmp +cuda are compatible - Updated to use setup_build_environment(), setup_run_environment() * amber: Adding missing flex and bison dependencies * Removed cray variant; flex and bison now build only * amber: Improved package.py and added version 18 - Added amber 18 with ambertools 19 - Added all available patches - Added +update variant to use the self update - Added +openmp variant to get openmp optomizations - Added +x11 variant when possible - Splitted amber 16 and 18 dependencies - We now detect the copiler type and compile accordingly - Added cray variant which is a bit special (untested) - Improved detection of possible cuda versions - All compilation optimizations +mpi +openmp +cuda are compatible - Updated to use setup_build_environment(), setup_run_environment() * amber: Adding missing flex and bison dependencies * Removed cray variant; flex and bison now build only * dealii: Fixed flake8 issues * amber: corrected typo * amber: Removed unused variant python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBB is an optional dependency of deal.II, used by the library to parallelize some operations with threads. If the cmake flag DEAL_II_WITH_THREADS (default: ON) is set to OFF, deal.II does not require TBB anymore. This pull request adds a variant 'threads' to the deal.II package with the same default behavior (+threads), which controls the TBB dependency.
The motivation for this pull request is that there is currently a bug in the Intel compiler (icpc version 19.0.3.199 (gcc version 8.3.0 compatibility)), that makes it impossible to compile deal.II with thread support enabled (a reference to one of the headers in TBB fires a "bad pointer" internal error in icpc). So without this variant, I could not build deal.II.