Closed
Conversation
…ating a process if it takes too long
2 tasks
Member
|
@scheibelp I'm going through old PRs and closing the ones that seem stale / outdated. Feel free to reopen if you disagree with me closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a timeout to fetching of resources in Spack. This assumes that any resource can be retrieved in a fixed amount of time (currently 10 minutes). The timeout is currently added only for git/URL resources (but could easily be added for any).
This is intended to address #13604, and to work as a catch-all for all issues which for one reason or another permanently stall fetching a resource. This could include:
Overall, this will only work well if timeouts are rare (since a large timeout is required to accommodate large downloads).