Variant for enabling tests, versions, cleanup#13882
Merged
adamjstewart merged 7 commits intospack:developfrom Nov 26, 2019
raovgarimella:develop
Merged
Variant for enabling tests, versions, cleanup#13882adamjstewart merged 7 commits intospack:developfrom raovgarimella:develop
adamjstewart merged 7 commits intospack:developfrom
raovgarimella:develop
Conversation
adamjstewart
requested changes
Nov 25, 2019
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
The point of the test-related changes I proposed is that we don't want the spec to be different based on whether or not unit tests were run during installation. Now, users will be able to run spack install --test=root to enable unit tests.
raovgarimella
commented
Nov 26, 2019
Contributor
Author
raovgarimella
left a comment
raovgarimella
left a comment
There was a problem hiding this comment.
Resolved all requested changes
Member
adamjstewart
left a comment
adamjstewart
left a comment
There was a problem hiding this comment.
The if 'foo' in spec lines aren't checking whether the variant is enabled, but if the dependency is present in the spec. all shouldn't be needed.
added 2 commits
November 25, 2019 20:56
adamjstewart
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added variant for enabling tests
Added option to retrieve variants
Split 'parallel=some_partitioner' variant into 'parallel=true/false' and 'partitioner=some_partitioner'
Added conflicts
General cleanup