add new package : httperf@master#13875
Merged
alalazo merged 3 commits intospack:developfrom Nov 26, 2019
Merged
Conversation
alalazo
approved these changes
Nov 25, 2019
alalazo
reviewed
Nov 25, 2019
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
One minor request before merging
alalazo
approved these changes
Nov 26, 2019
alalazo
requested changes
Nov 26, 2019
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
Apologies, I missed on a first read that we have no released versions. Since this package is only using VCS we can't rely on https://github.com/httperf/httperf/archive/master.zip staying the same as time passes. Can you specify the git repository with a git attribute and either pin a specific commit hash or use:
version('master', branch='master'`)?
Contributor
Author
|
@alalazo |
alalazo
approved these changes
Nov 26, 2019
Member
|
Thanks for the quick reply @darmac . Waiting for Travis to go green and then merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.