Skip to content

ncurses: don't run strip internally#13843

Merged
junghans merged 3 commits intodevelopfrom
hotfix/ncurses
Nov 24, 2019
Merged

ncurses: don't run strip internally#13843
junghans merged 3 commits intodevelopfrom
hotfix/ncurses

Conversation

@junghans
Copy link
Copy Markdown
Contributor

@junghans junghans commented Nov 22, 2019

@junghans junghans requested a review from healther November 22, 2019 17:09
Copy link
Copy Markdown
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question to understand the purpose of this PR

@junghans
Copy link
Copy Markdown
Contributor Author

Found here: https://api.travis-ci.org/v3/job/614871616/log.txt

The error is actually:

strip:/home/ci/spack/opt/spack/linux-fedora31-haswell/gcc-9.2.1/ncurses-6.1-up3eftkq4gbvsod2pz35hsmtyzyu55hp/bin/tic[.gnu.build.attributes]: corrupt GNU build attribute note: wrong note type: bad value
/usr/bin/install: strip process terminated abnormally

Happens on Fedora 31.

@junghans junghans changed the title ncurses: don't run ldconfig ncurses: don't run strip internally Nov 23, 2019
@adamjstewart
Copy link
Copy Markdown
Member

Need to replace setup_environment with setup_build_environment

@junghans junghans merged commit 8b1d800 into develop Nov 24, 2019
@junghans junghans deleted the hotfix/ncurses branch November 24, 2019 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants