Skip to content

Add unit test on MacOS using Github Actions#13826

Closed
alalazo wants to merge 13 commits intospack:developfrom
alalazo:qa/macos_unit_tests
Closed

Add unit test on MacOS using Github Actions#13826
alalazo wants to merge 13 commits intospack:developfrom
alalazo:qa/macos_unit_tests

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Nov 21, 2019

No description provided.

@alalazo alalazo added macOS tests General test capability(ies) labels Nov 21, 2019
@alalazo alalazo force-pushed the qa/macos_unit_tests branch from 0b58bdb to b94abf9 Compare November 21, 2019 22:06
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Nov 21, 2019

@tgamblin The good news is that MacOS tests run in 15 min. total instead of 40mins + waiting for the worker, the bad one is that there are 2 tests failing possibly because stdout is not captured by pytest for some reason.

Do you have a codecov token stored in the repo secrets? If so what is its name?

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Nov 22, 2019

I had to skip 2 tests and the output is not captured by pytest but printed to stdout. Apart from that MacOS tests are working and they run in ~15 min with no waiting time. Wondering if you have comments on the workflow so far.

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Nov 26, 2019

I fixed one of the two tests failing. The other one can probably be reworked not to check stdout, but I'll leave it as it is for now. The nice thing is that MacOS now completes in 18 mins. - way before Travis. Waiting for the name of codecov's token so that we can get rid of the annoying red cross (-0.27% on project, due to MAcOS being testes only on develop).

@alalazo alalazo force-pushed the qa/macos_unit_tests branch from c8dc061 to 166c0f2 Compare December 5, 2019 10:10
@alalazo alalazo closed this Dec 19, 2019
@alalazo alalazo deleted the qa/macos_unit_tests branch December 19, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

don't-merge-yet macOS tests General test capability(ies)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant