Skip to content

Fixed detection for cascadelake microarchitecture#13820

Merged
becker33 merged 1 commit intospack:developfrom
alalazo:fixes/cascadelake-detection
Nov 21, 2019
Merged

Fixed detection for cascadelake microarchitecture#13820
becker33 merged 1 commit intospack:developfrom
alalazo:fixes/cascadelake-detection

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Nov 21, 2019

fixes #13803

@alalazo alalazo added platform-support bugfix Something wasn't working, here's a fix labels Nov 21, 2019
@ifelsefi
Copy link
Copy Markdown
Contributor

Nice

@ifelsefi
Copy link
Copy Markdown
Contributor

Confirmed, this fixes the problem

[root@phobos centos7]# source /software/spack/centos7/share/spack/setup-env.sh
[root@phobos centos7]# spack arch
linux-centos7-cascadelake

@ifelsefi
Copy link
Copy Markdown
Contributor

Can this be merged?

@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Nov 21, 2019

@ifelsefi When I get a review and Travis finishes sure 🙂

@becker33 becker33 merged commit 0684a58 into spack:develop Nov 21, 2019
@alalazo alalazo deleted the fixes/cascadelake-detection branch November 21, 2019 20:10
@scheibelp scheibelp removed their assignment Nov 21, 2019
@tgamblin
Copy link
Copy Markdown
Member

tgamblin commented Dec 2, 2019

Moving this to 0.14, as it'll change specs, and it's conflicted with #13780.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cascadelake detected as skylake_avx512

5 participants