Skip to content

add package [email protected]#13819

Merged
adamjstewart merged 3 commits intospack:developfrom
psychocoderHPC:topic-addCuda10.2Support
Nov 25, 2019
Merged

add package [email protected]#13819
adamjstewart merged 3 commits intospack:developfrom
psychocoderHPC:topic-addCuda10.2Support

Conversation

@psychocoderHPC
Copy link
Copy Markdown
Contributor

add CUDA 10.2 support
@ax3l
Copy link
Copy Markdown
Member

ax3l commented Nov 25, 2019

There is a bit more to it, let me re-open this quickly.
Update: I was able to push to this, that works as well.

@ax3l ax3l force-pushed the topic-addCuda10.2Support branch from d02be38 to 2503663 Compare November 25, 2019 08:38
@ax3l ax3l requested review from alalazo and davydden November 25, 2019 08:39
@ax3l ax3l added the cuda label Nov 25, 2019
@psychocoderHPC
Copy link
Copy Markdown
Contributor Author

psychocoderHPC commented Nov 25, 2019

@ax3l thx for help. The CI is still failing because of some old API usages: https://travis-ci.org/spack/spack/jobs/616567011#L3800-L3801

I am not sure what does this means.

@ax3l
Copy link
Copy Markdown
Member

ax3l commented Nov 25, 2019

No problem, CI just found we did not update the cuda package with the new syntax in #11115. I fixed it now.

def setup_environment(self, spack_env, run_env):
run_env.set('CUDA_HOME', self.prefix)
def setup_run_environment(self, env):
env.set('CUDA_HOME', self.prefix)
Copy link
Copy Markdown
Contributor

@nazavode nazavode Dec 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the reason for #13969.

EDIT: I'm probably wrong here, but I have no other clue about why git bisect found this change set other than this hunk that operates on environments, the rest looks harmless to me.

Copy link
Copy Markdown
Member

@ax3l ax3l Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that environment variable is the reason since the same environment was set before.
The underlying reason probably stems from the introduction of libcu++ with CUDA 10.2, which ships its own device-enabled stdlib.

Copy link
Copy Markdown
Member

@ax3l ax3l Dec 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you wrote in #13969, implementation details of this nvidia stdlib are exposed by spack as regular include paths, which cause your issue.
Could be rooted in the find_libraries('libcuda', ..., recursive=True) thing below that was introduced by @scheibelp in #11449 . I also have to catch up on what this does, have not seen it before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants