Bugfix/mirror all patch conflicts#13789
Merged
scheibelp merged 8 commits intospack:developfrom Nov 21, 2019
Merged
Conversation
- Appends part of the patch has to the patch name to differentiate patches with the same name (for the same package). - Patches are re-downloaded if the file isn't at the storage path or it's cosmetic name are missing. - Fixed an exception handling error in mirror.py (not all exceptions) have a 'message' attribute.
scheibelp
requested changes
Nov 19, 2019
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
I have a few requests. Also:
- Flake is failing right now
- I updated the PR description to mention a similar PR (but the other one is a subset and doesn't fix all the issues this PR does).
Thanks!
- Removed changes to mpfr - Changed 8 bytes of hash to 7 - Used suggested comment.
Now the staging will fetch the file if it doesn't already exist, and will create the symlink if it's missing as a separate step.
scheibelp
approved these changes
Nov 20, 2019
Member
|
Thanks! |
This was referenced Nov 21, 2019
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Dec 10, 2019
fixes spack#14067 In spack#13789 an absolute path was erroneously substituted with a relative one, causing broken links in mirrors. This PR restores the absolute path and adds a unit test to avoid regressions.
tgamblin
pushed a commit
that referenced
this pull request
Dec 24, 2019
…ling (#13789) * Some packages (e.g. mpfr at the time of this patch) can have patches with the same name but different contents (which apply to different versions of the package). This appends part of the patch hash to the cache file name to avoid conflicts. * Some exceptions which occur during fetching are not a subclass of SpackError and therefore do not have a 'message' attribute. This updates the logic for mirroring a single spec (add_single_spec) to produce an appropriate error message in that case (where before it failed with an AttributeError) * In various circumstances, a mirror can contain the universal storage path but not a cosmetic symlink; in this case it would not generate a symlink. Now "spack mirror create" will create a symlink for any package that doesn't have one.
samiilvonen
pushed a commit
to CSCfi/spack
that referenced
this pull request
Jan 10, 2020
…ling (spack#13789) * Some packages (e.g. mpfr at the time of this patch) can have patches with the same name but different contents (which apply to different versions of the package). This appends part of the patch hash to the cache file name to avoid conflicts. * Some exceptions which occur during fetching are not a subclass of SpackError and therefore do not have a 'message' attribute. This updates the logic for mirroring a single spec (add_single_spec) to produce an appropriate error message in that case (where before it failed with an AttributeError) * In various circumstances, a mirror can contain the universal storage path but not a cosmetic symlink; in this case it would not generate a symlink. Now "spack mirror create" will create a symlink for any package that doesn't have one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13622
patches with the same name (for the same package).
or it's cosmetic name are missing.
have a 'message' attribute.