Py-pymol package has been updated to the latest version#13764
Merged
adamjstewart merged 13 commits intospack:developfrom Nov 26, 2019
hseara:py-pymol
Merged
Py-pymol package has been updated to the latest version#13764adamjstewart merged 13 commits intospack:developfrom hseara:py-pymol
adamjstewart merged 13 commits intospack:developfrom
hseara:py-pymol
Conversation
Contributor
hseara
commented
Nov 17, 2019
hseara
commented
- I have removed the previous py-pymol version as it was no longer compiling
- I have added a new package libmmtf-cpp that is a new dependency of py-pymol
This patch is borrowed from archlinux https://bugs.archlinux.org/task/39526
Contributor
Author
|
Any problem with this submission, or I just have to wait for a reviewer? |
| depends_on('libmmtf-cpp', type=('build')) | ||
| depends_on('msgpack-c', type=('build')) | ||
|
|
||
| patch('apbstools_tcltk8.6.patch', level=0, when='@2.3.0') |
Member
There was a problem hiding this comment.
Can you explain this patch in more detail? Why is it necessary? Has it been submitted upstream?
Contributor
Author
There was a problem hiding this comment.
@adamjstewart I just copied the patch from the archlinux pymol installation. But a more careful inspection makes me believe that it is not needed. First, the plugin it tries to fix is outdated. Also, we do not provide apbs support at this moment, so it is useless.
Contributor
Author
|
adamjstewart
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.