Skip to content

cmd/install: remove unused install_status option#13751

Merged
becker33 merged 2 commits intodevelopfrom
bugfix/remove-unused-status-option-cmd-install
Nov 22, 2019
Merged

cmd/install: remove unused install_status option#13751
becker33 merged 2 commits intodevelopfrom
bugfix/remove-unused-status-option-cmd-install

Conversation

@becker33
Copy link
Copy Markdown
Member

Pretty straightforward. The option isn't actually hooked up to any functionality, and I'm not sure how it got into the install command.

Motivated by the error report on slack that confused it with the similarly named option for the spack spec command.

@alalazo
Copy link
Copy Markdown
Member

alalazo commented Nov 15, 2019

@becker33 Looking at git blame it seems to come from e63b45b.

@becker33
Copy link
Copy Markdown
Member Author

@alalazo that's just where it was refactored, it came in from d1cce99 originally. There doesn't appear to be any reason it was included there (and no code in cmd/install.py has ever referenced the value it stores) so I think we're fine removing it.

@adamjstewart
Copy link
Copy Markdown
Member

May need to update bash completion script

@becker33
Copy link
Copy Markdown
Member Author

@adamjstewart done.

@becker33 becker33 merged commit 6c55a7c into develop Nov 22, 2019
@adamjstewart adamjstewart deleted the bugfix/remove-unused-status-option-cmd-install branch November 22, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants