ocaml: Fix version conversion process#13749
Merged
adamjstewart merged 1 commit intospack:developfrom Nov 26, 2019
Merged
Conversation
Member
|
I'm wondering if we should fix this more generally. The culprit for this bug is https://github.com/spack/spack/blob/develop/lib/spack/spack/version.py#L112. But this line has been there for 7 years, so I have no idea what the consequences of removing |
Member
|
Merging this for now just so we can get OCaml working again. We should still think about whether we want to fix this more generally. |
Contributor
Author
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The download url of the ocaml package was invalid because the following error occurred.
"The requested url returned error: 404 Not Found"
The purpose is to convert the version
4.06.0to4.06But, when using up_to,
4.06was converted to4.6.http://caml.inria.fr/pub/distrib/ocaml-4.6/ocaml-4.06.0.tar.gz
http://caml.inria.fr/pub/distrib/ocaml-4.06/ocaml-4.06.0.tar.gz
So I converted the string of version in the recipe without using up_to.