Allow binary relocation of strings in relative binaries#13724
Merged
scheibelp merged 2 commits intoreleases/v0.13from Nov 14, 2019
Merged
Allow binary relocation of strings in relative binaries#13724scheibelp merged 2 commits intoreleases/v0.13from
scheibelp merged 2 commits intoreleases/v0.13from
Conversation
scheibelp
requested changes
Nov 13, 2019
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
There is one variable reference issue and I have a couple comments on clarity.
| if not rel: | ||
| if rel: | ||
| if old_path != new_path: | ||
| files_to_relocate = list(filter( |
Member
There was a problem hiding this comment.
This is a bit much to unpack. I think the filter function ought to be defined separately.
Also, should we report those members of relocate_binaries that are not in fact relocatable?
Member
Author
There was a problem hiding this comment.
We get a lot of false positives for inability to relocate, because lots of things have paths hardcoded in their dwarf info or elsewhere that do not affect correctness. That's why I switched to a single warning per-package.
scheibelp
approved these changes
Nov 13, 2019
tgamblin
added a commit
that referenced
this pull request
Dec 5, 2019
v0.13.2 This release contains major performance improvements for Spack environments, as well as some bugfixes and minor changes. * allow missing modules if they are blacklisted (#13540) * speed up environment activation (#13557) * mirror path works for unknown versions (#13626) * environments: don't try to modify run-env if a spec is not installed (#13589) * use semicolons instead of newlines in module/python command (#13904) * verify.py: os.path.exists exception handling (#13656) * Document use of the maintainers field (#13479) * bugfix with config caching (#13755) * hwloc: added 'master' version pointing at the HEAD of the master branch (#13734) * config option to allow gpg warning suppression (#13744) * fix for relative symlinks when relocating binary packages (#13727) * allow binary relocation of strings in relative binaries (#13724)
tgamblin
added a commit
that referenced
this pull request
Dec 5, 2019
v0.13.2 This release contains major performance improvements for Spack environments, as well as some bugfixes and minor changes. * allow missing modules if they are blacklisted (#13540) * speed up environment activation (#13557) * mirror path works for unknown versions (#13626) * environments: don't try to modify run-env if a spec is not installed (#13589) * use semicolons instead of newlines in module/python command (#13904) * verify.py: os.path.exists exception handling (#13656) * Document use of the maintainers field (#13479) * bugfix with config caching (#13755) * hwloc: added 'master' version pointing at the HEAD of the master branch (#13734) * config option to allow gpg warning suppression (#13744) * fix for relative symlinks when relocating binary packages (#13727) * allow binary relocation of strings in relative binaries (#13724)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binaries with relative RPATHS currently do not relocate strings hard-coded in binaries
This PR extends the best-effort relocation of strings hard-coded in binaries to those whose RPATHs have been relativized.
A separate PR will be made to the develop branch