Binary packaging: correct relative symlinks#13710
Merged
becker33 merged 1 commit intospack:developfrom Nov 14, 2019
Merged
Conversation
…link path (which includes the file name)
becker33
approved these changes
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@becker33
Something I missed when reviewing #10073
relocate.make_link_relativewas resolving a path relative to a complete file path when in factos.path.relpathexpects a directory. The result was that the relative path was always "off" by one directory in the sense that it always added an extra initial../to the path.This determines the link target relative path relative to the link directory rather than relative to the full link path (which includes the file name).