Skip to content

Update Mathematica recipe#13679

Merged
adamjstewart merged 3 commits intospack:developfrom
brisk022:develop
Nov 26, 2019
Merged

Update Mathematica recipe#13679
adamjstewart merged 3 commits intospack:developfrom
brisk022:develop

Conversation

@brisk022
Copy link
Copy Markdown
Contributor

This pull request addresses the following issues.

  • Licensing is currently missing from the recipe. Assuming that majority of the installations will be on clusters, information about the licence manager server would be required
  • Replace url with url_for_version in case subsequent versions are added
  • Create .spack dir during installation. This directory may not be created automatically causing installation failure when spack is trying to copy the log file there.
  • Symlink wolframscript. Most people running mathematica in the cluster environment would be using wolframscript binary. However, the installer does not symlink it, so full path is required to run it.
  • Generate spec.yaml. This file may not be created automatically causing package registration failure.

…ring installation; symlink wolframscript; generate spec.yaml if missing
@brisk022
Copy link
Copy Markdown
Contributor Author

I have created a bug report for the problem with missing .spack directory and spec.yaml #13718

@adamjstewart
Copy link
Copy Markdown
Member

Flake8:

var/spack/repos/builtin/packages/mathematica/package.py:38: [E501] line too long (95 > 79 characters)
var/spack/repos/builtin/packages/mathematica/package.py:44: [W391] blank line at end of file

@adamjstewart
Copy link
Copy Markdown
Member

Ping @brisk022

@adamjstewart adamjstewart merged commit eb05617 into spack:develop Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants