verify.py: os.path.exists exception handling#13656
Merged
becker33 merged 1 commit intospack:developfrom Nov 11, 2019
DarylGrunau:bugfix/verify-path-exists-exception
Merged
verify.py: os.path.exists exception handling#13656becker33 merged 1 commit intospack:developfrom DarylGrunau:bugfix/verify-path-exists-exception
becker33 merged 1 commit intospack:developfrom
DarylGrunau:bugfix/verify-path-exists-exception
Conversation
This was referenced Nov 8, 2019
Member
|
I just hit this same bug today when trying to install |
becker33
approved these changes
Nov 11, 2019
tgamblin
pushed a commit
that referenced
this pull request
Dec 2, 2019
tgamblin
added a commit
that referenced
this pull request
Dec 5, 2019
v0.13.2 This release contains major performance improvements for Spack environments, as well as some bugfixes and minor changes. * allow missing modules if they are blacklisted (#13540) * speed up environment activation (#13557) * mirror path works for unknown versions (#13626) * environments: don't try to modify run-env if a spec is not installed (#13589) * use semicolons instead of newlines in module/python command (#13904) * verify.py: os.path.exists exception handling (#13656) * Document use of the maintainers field (#13479) * bugfix with config caching (#13755) * hwloc: added 'master' version pointing at the HEAD of the master branch (#13734) * config option to allow gpg warning suppression (#13744) * fix for relative symlinks when relocating binary packages (#13727) * allow binary relocation of strings in relative binaries (#13724)
tgamblin
added a commit
that referenced
this pull request
Dec 5, 2019
v0.13.2 This release contains major performance improvements for Spack environments, as well as some bugfixes and minor changes. * allow missing modules if they are blacklisted (#13540) * speed up environment activation (#13557) * mirror path works for unknown versions (#13626) * environments: don't try to modify run-env if a spec is not installed (#13589) * use semicolons instead of newlines in module/python command (#13904) * verify.py: os.path.exists exception handling (#13656) * Document use of the maintainers field (#13479) * bugfix with config caching (#13755) * hwloc: added 'master' version pointing at the HEAD of the master branch (#13734) * config option to allow gpg warning suppression (#13744) * fix for relative symlinks when relocating binary packages (#13727) * allow binary relocation of strings in relative binaries (#13724)
samiilvonen
pushed a commit
to CSCfi/spack
that referenced
this pull request
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds exception handling around the
os.stat()call during manifest creation so that installation of packages can run to completion should the package itself insert bogus files (e.g. a dangling symlink) into its install directory. Without this patch, if any package so misbehaves, thepost_install()section fails like this (even if the package itself successfully builds!):Fixes #13648
Fixes #13649