bugfix: mirror path works for unknown versions#13626
Merged
Conversation
`mirror_archive_path` was failing to acccount for the case where the fetched versions isn't known to Spack. - [x] don't require the fetched version to be in `Package.versions`
Member
Author
|
@zzotta: does this fix your fetch command? It does for me: $ spack fetch --no-checksum [email protected]
==> Warning: [email protected] cannot build optimized binaries for "skylake". Using best target possible: "x86_64"
==> Fetching file:///Users/gamblin2/foop/libbson/libbson-1.9.5.tar.gz
curl: (37) Couldn't open file /Users/gamblin2/foop/libbson/libbson-1.9.5.tar.gz
==> Fetching from file:///Users/gamblin2/foop/libbson/libbson-1.9.5.tar.gz failed.
==> Fetching https://github.com/mongodb/libbson/releases/download/1.9.5/libbson-1.9.5.tar.gz
######################################################################## 100.0% |
Contributor
Member
|
@tgamblin I agree with the changes you made, so if you agree with the test I added then this is good to go |
scheibelp
force-pushed
the
bugfix/mirror-path-fails-for-nonexistant-version
branch
from
1be275d to
cb15be8
Compare
becker33
approved these changes
Nov 7, 2019
Member
Author
|
@scheibelp: this looks good to me! @junghans: FYI, I think this fixes the issue we saw in the tutorial Tuesday. |
tgamblin
changed the title
tgamblin
added a commit
that referenced
this pull request
Dec 2, 2019
`mirror_archive_path` was failing to account for the case where the fetched version isn't known to Spack. - [x] don't require the fetched version to be in `Package.versions` - [x] add regression test for mirror paths when package does not have a version
tgamblin
added a commit
that referenced
this pull request
Dec 5, 2019
v0.13.2 This release contains major performance improvements for Spack environments, as well as some bugfixes and minor changes. * allow missing modules if they are blacklisted (#13540) * speed up environment activation (#13557) * mirror path works for unknown versions (#13626) * environments: don't try to modify run-env if a spec is not installed (#13589) * use semicolons instead of newlines in module/python command (#13904) * verify.py: os.path.exists exception handling (#13656) * Document use of the maintainers field (#13479) * bugfix with config caching (#13755) * hwloc: added 'master' version pointing at the HEAD of the master branch (#13734) * config option to allow gpg warning suppression (#13744) * fix for relative symlinks when relocating binary packages (#13727) * allow binary relocation of strings in relative binaries (#13724)
tgamblin
added a commit
that referenced
this pull request
Dec 5, 2019
v0.13.2 This release contains major performance improvements for Spack environments, as well as some bugfixes and minor changes. * allow missing modules if they are blacklisted (#13540) * speed up environment activation (#13557) * mirror path works for unknown versions (#13626) * environments: don't try to modify run-env if a spec is not installed (#13589) * use semicolons instead of newlines in module/python command (#13904) * verify.py: os.path.exists exception handling (#13656) * Document use of the maintainers field (#13479) * bugfix with config caching (#13755) * hwloc: added 'master' version pointing at the HEAD of the master branch (#13734) * config option to allow gpg warning suppression (#13744) * fix for relative symlinks when relocating binary packages (#13727) * allow binary relocation of strings in relative binaries (#13724)
samiilvonen
pushed a commit
to CSCfi/spack
that referenced
this pull request
Jan 10, 2020
`mirror_archive_path` was failing to account for the case where the fetched version isn't known to Spack. - [x] don't require the fetched version to be in `Package.versions` - [x] add regression test for mirror paths when package does not have a version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a second error mentioned by @zzotta in #13474 (comment).
mirror_archive_pathwas failing to account for the case where the fetched version isn't known to Spack.Package.versions