Bugfix: different patches with same name#13622
Closed
scheibelp wants to merge 3 commits intospack:developfrom
Closed
Bugfix: different patches with same name#13622scheibelp wants to merge 3 commits intospack:developfrom
scheibelp wants to merge 3 commits intospack:developfrom
Conversation
…fferent package versions; note that dependency patches currently must have different names
…e for different package versions; note that dependency patches currently must have different names" This reverts commit 8108bec.
… mirror name for a patch that applies to multiple versions
Member
Author
|
@tgamblin this changes the format of patch filenames in the cache (not the global ones but rather the easier-to-read ones) but that is required to store the same patch for different versions in the mirror. |
scheibelp
changed the title
michaelkuhn
approved these changes
Nov 8, 2019
Member
michaelkuhn
left a comment
michaelkuhn
left a comment
There was a problem hiding this comment.
Works for me. Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13611
@michaelkuhn do you mind if this is resolved by changing the name that's stored in the mirror?