Fix issue where fetch failed to prefer local mirrors over public remote resources#13545
Merged
tgamblin merged 4 commits intospack:developfrom Nov 4, 2019
Merged
Conversation
…te resources Also updates the S3FetchStrategy so that it throws a SpackError if the fetch fails. Before, it was throwing URLError, which was not being caught in stage.py
scheibelp
requested changes
Nov 1, 2019
Member
scheibelp
left a comment
scheibelp
left a comment
There was a problem hiding this comment.
I have one request and one question, let me know if you disagree. Thanks!
scheibelp
approved these changes
Nov 1, 2019
Member
|
Pending the flake update, this looks good to me |
scheibelp
reviewed
Nov 1, 2019
tgamblin
approved these changes
Nov 4, 2019
tgamblin
pushed a commit
that referenced
this pull request
Nov 4, 2019
…13545) - [x] insert at beginning of list so fetch grabs local mirrors before remote resources - [x] update the S3FetchStrategy so that it throws a SpackError if the fetch fails. Before, it was throwing URLError, which was not being caught in stage.py. - [x] move error handling out of S3FetchStrategy and into web_util.read_from_url() - [x] pass string instead of URLError to SpackWebError
|
@tgamblin, is this change also going to go into the next minor release of the line 0.13.x? |
Member
|
@bartlettroscoe yes: everything that is added to the https://github.com/spack/spack/projects/13 (which appears under the "projects" section of the PR page) will be in 0.13.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates the S3FetchStrategy so that it throws a SpackError if the fetch fails. Before, it was throwing URLError, which was not being caught in stage.py. (This uncaught exception is what had originally confused me and led to my erroneous changes in
stage.py.)Fixes #13537