fix issue where spack.util.url.join() failed to correctly handle absolute path components#13488
Merged
tgamblin merged 4 commits intospack:developfrom Nov 1, 2019
Merged
Conversation
…lute path components
Member
Author
|
CI looks good. I am working on adding tests. |
Member
Contributor
|
Yes, I've confirmed with a few different packages using |
opadron
force-pushed
the
fix/13474-bad-checksum-urls
branch
from
7551364 to
f47e7b8
Compare
tgamblin
approved these changes
Nov 1, 2019
Member
tgamblin
left a comment
tgamblin
left a comment
There was a problem hiding this comment.
Ok this is much better with tests. Thanks!
I still think this code can be simplified quite a bit (or perhaps we could think about how we handle the netloc/path relationship for s3), but that can happen in some future PR.
tgamblin
pushed a commit
that referenced
this pull request
Nov 1, 2019
…13488) * fix issue where spack.util.url.join() failed to correctly handle absolute path components * add url util tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to resolve #13474.
Other fixes might be necessary.