Bugfix: syaml_int repr for Python 3.8.0#13487
Merged
tgamblin merged 1 commit intospack:developfrom Oct 29, 2019
Merged
Conversation
Member
|
Feel free to steal #13347 if you really want to test this. |
Member
Author
|
@adamjstewart thanks - I tested with 3.8.0 manually as part of figuring out what the issue was so I think this is set |
scheibelp
changed the title
tgamblin
approved these changes
Oct 29, 2019
Member
|
Thanks @scheibelp! |
jrmadsen
pushed a commit
to jrmadsen/spack
that referenced
this pull request
Oct 30, 2019
tgamblin
pushed a commit
that referenced
this pull request
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13247
Fixes #13355
#13247 (comment) notes that python 3.8.0 removes
__str__fromint, so for python 3.8.0 invocations ofint.__str__fall back onint.__repr__. Spack'ssyaml_inttype assigns__repr__ = str.__repr__which appears to be causing failures.This updates
syaml_inttype to useint.__repr__rather thanstr.__repr__, which allows running Spack with Python 3.8.0 and assigning integer configuration settings.