Restore upstream lock safety, avoid calling methods directly on upstream DB in test#13441
Merged
tldahlgren merged 2 commits intospack:developfrom Oct 25, 2019
Merged
Conversation
…nly be called on the local DB (which knows how when to lock and when not to)
scheibelp
changed the title
scheibelp
changed the title
tldahlgren
approved these changes
Oct 25, 2019
Contributor
tldahlgren
left a comment
tldahlgren
left a comment
There was a problem hiding this comment.
Reviewed the tests in context plus they both pass for me.
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #13364
A merge created a semantic error for managing upstream DB locks: upstream DBs are not supposed to be locked at all but the
ForbiddenLockobject used to manage this was overwritten.Additionally, an upstream db test was calling methods on upstream DBs that should only be called on the local DB (which knows how when to lock and when not to). This updates the test to avoid that, and also adds a regression test to make sure that writing to upstream DBs leads to an exception.