Merged
Conversation
adamjstewart
requested changes
Oct 28, 2019
Member
|
Ping @healther |
Contributor
Author
|
I'd prefer not to change up any old versions (at least not without checking the versions manually, for which I don't have the time)... At some point there was some discussion about adding logic to parse |
Contributor
Author
|
@adamjstewart: The dependencies are plain in |
Member
|
That's fine, you still need to address the other comments though. |
healther
force-pushed
the
PR/pynbconvert
branch
from
5fce177 to
9b5658d
Compare
adamjstewart
requested changes
Nov 7, 2019
* add setuptools dependency, like all the other jupyter packages it seems to be using setuptools for some commands all the time but requires it for the newest version * added dependencies, not necessarily only needed for the latest one * depends on new packages (defusedxml, pandocfilters, testpath) * should also be moved to pypi sources? * '@5:@5:' is a valid spec -> intended?
healther
force-pushed
the
PR/pynbconvert
branch
from
9b5658d to
8ccfbbc
Compare
Contributor
Author
|
sorry for the delay, I was on vacation the last 3 weeks |
adamjstewart
requested changes
Nov 25, 2019
Co-Authored-By: Adam J. Stewart <[email protected]>
adamjstewart
approved these changes
Nov 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it seems to be using setuptools for some commands all the time
but requires it for the newest version