Skip to content

[WIP] Fixes/upstream locks#13364

Closed
tldahlgren wants to merge 3 commits intospack:developfrom
tldahlgren:fixes/upstream_locks
Closed

[WIP] Fixes/upstream locks#13364
tldahlgren wants to merge 3 commits intospack:developfrom
tldahlgren:fixes/upstream_locks

Conversation

@tldahlgren
Copy link
Copy Markdown
Contributor

@tldahlgren tldahlgren commented Oct 21, 2019

Fixes #8772

When chaining Spack installations, the upstream Spack instance is not supposed to be locked; however, that is not currently the case.

This PR ensures the ForbiddenLock is retained for upstream databases and associated operations do not attempt to acquire read locks.

TODO:

  • Resolve test failure issues

@tldahlgren tldahlgren added bug Something isn't working pkg-database locking labels Oct 21, 2019
@tldahlgren tldahlgren self-assigned this Oct 21, 2019
@tldahlgren tldahlgren added WIP bugfix Something wasn't working, here's a fix and removed bug Something isn't working labels Oct 21, 2019
@tldahlgren
Copy link
Copy Markdown
Contributor Author

The lock and corresponding database test fixes are done in #13441

@tldahlgren tldahlgren closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something wasn't working, here's a fix locking WIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants