Strict dependency constraint checking#13243
Merged
tgamblin merged 1 commit intospack:developfrom Oct 17, 2019
Merged
Conversation
tgamblin
approved these changes
Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Satisfaction checks on dependencies should be strict when the parent check is strict
This is intended for constraints like
currently, Spack will add the
py-backports-functools-lru-cachedependency at a point in the concretization when the dependency is just^python(without a version) because strict constraint checking does not propagate to dependency constraint checking.Note that because the concretizer is greedy, the constraints applied by the
py-backports-functools-lru-cachedependency will be applied later and may generate concretizer conflicts (which requires the user to specify certain constraints on the command line), but this avoids the concretizer incorrectly adding thepy-backports-functools-lru-cachedependency.An example package this fixes is
py-soupsieve.