Autotools build system to patch config.guess based on a range check#13186
Merged
tgamblin merged 1 commit intospack:developfrom Oct 12, 2019
Merged
Autotools build system to patch config.guess based on a range check#13186tgamblin merged 1 commit intospack:developfrom
tgamblin merged 1 commit intospack:developfrom
Conversation
Contributor
|
@alalazo for my education, what does the ":" range specification mean w.r.t. an arch? |
Member
Author
|
@lee218llnl Before #3206 archs were coarse grained, like $ spack arch --known-targets
Generic architectures (families)
aarch64 arm ppc ppc64 ppc64le ppcle sparc sparc64 x86 x86_64
GenuineIntel - x86
i686 pentium2 pentium3 pentium4 prescott
GenuineIntel - x86_64
nocona core2 nehalem westmere sandybridge ivybridge haswell broadwell skylake mic_knl skylake_avx512 cannonlake cascadelake icelake
AuthenticAMD - x86_64
bulldozer zen piledriver zen2 steamroller excavator
IBM - ppc64
power7 power8 power9
IBM - ppc64le
power8le power9leThe microarchitectures above can be organized in graphs representing "families". An open range like |
alalazo
force-pushed
the
fixes/patch_config_guess_marchs
branch
from
3109884 to
5d9837f
Compare
tgamblin
approved these changes
Oct 11, 2019
Member
|
Should we just keep a |
Member
|
Yes, this patch fixes #13196 for me. |
tgamblin
approved these changes
Oct 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13196
The fix reverts the semantic meaning of this check to what was before #3206