Bootstrap environment modules optimizing for generic architectures#13105
Bootstrap environment modules optimizing for generic architectures#13105tgamblin merged 2 commits intospack:developfrom
Conversation
fixes spack#13073 Since spack#3206 was merged bootstrapping environment-modules was using the architecture of the current host or the best match supported by the default compiler. The former case is an issue since shell integration was looking for a spec targeted at the host microarchitecture. This commit fixes the problem by: 1. Bootstrapping an en modules targeted at generic architectures 2. Looking for generic targets in shell integration scripts
|
@bassenj Can you confirm this fixes the issue for you? |
$ spack find
==> 3 installed packages
-- linux-ubuntu19.04-x86_64 / [email protected] -------------------------
[email protected] [email protected] [email protected]$ spack --print-shell-vars modules
_sp_sys_type='linux-ubuntu19.04-zen2'
_sp_compatible_sys_types='linux-ubuntu19.04-zen2:linux-ubuntu19.04-zen:linux-ubuntu19.04-x86_64'
_sp_tcl_roots='/tests/spack/share/spack/modules'
_sp_lmod_roots='/tests/spack/share/spack/lmod'
_sp_module_prefix='/tests/spack/opt/spack/linux-ubuntu19.04-x86_64/gcc-8.3.0/environment-modules-4.3.1-6fxrie7v4tfkvtbqt24jt6ytyofpmm36'
|
|
@bassenj Your architecture is recognized as User docs contains more details on specific microarchitecture support if you're interested. |
|
To reviewers: I added an additional job in Travis and put it into the first stage to make it fail fast in case it was not working correctly. If you think it belongs somewhere else this can be moved around and / or the corresponding stage can be renamed. |
|
Ok, I see, it is only falling back for bootstrapping and the bash functions and $ spack install python
...
$ spack find
==> 22 installed packages
-- linux-ubuntu19.04-x86_64 / [email protected] -------------------------
[email protected] [email protected] [email protected]
-- linux-ubuntu19.04-zen / [email protected] ----------------------------
[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
[email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected]
$ spack install zlib target=zen2
==> Error: cannot produce optimized binary for micro-architecture 'zen2' with [email protected] [supported compiler versions are 9:]There is a duplicate $ type module
module is a function
module ()
{
eval `/tests/spack/opt/spack/linux-ubuntu19.04-zen/gcc-8.3.0/environment-modules-4.3.1-lbrd2b7vesqpvgaxx4fkdqgya557fgpk/bin/modulecmd bash $*`
}Would it be possible to have another stage during bootstrapping that installs |
…pack#13105) fixes spack#13073 Since spack#3206 was merged bootstrapping environment-modules was using the architecture of the current host or the best match supported by the default compiler. The former case is an issue since shell integration was looking for a spec targeted at the host microarchitecture. 1. Bootstrap an env modules targeted at generic architectures 2. Look for generic targets in shell integration scripts 3. Add a new entry in Travis to test shell integration
fixes #13073
Since #3206 was merged bootstrapping environment-modules was using the architecture of the current host or the best match supported by the default compiler. The former case is an issue since shell integration was looking for a spec targeted at the host microarchitecture.
This commit fixes the problem by: