Skip to content

Add cuda to paraview build.#12996

Merged
adamjstewart merged 1 commit intospack:developfrom
danlipsa:paraview-cuda
Oct 2, 2019
Merged

Add cuda to paraview build.#12996
adamjstewart merged 1 commit intospack:developfrom
danlipsa:paraview-cuda

Conversation

@danlipsa
Copy link
Copy Markdown
Contributor

@danlipsa danlipsa commented Oct 1, 2019

No description provided.

@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Oct 1, 2019

@chuckatkins Please review.

Copy link
Copy Markdown
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this require a cuda dependency?

Also, can we merge the python and python3 variants?

@danlipsa
Copy link
Copy Markdown
Contributor Author

danlipsa commented Oct 1, 2019

Doesn't this require a cuda dependency?

This is done by CudaPackage isn't it?

Also, can we merge the python and python3 variants?

This is what we tried first but we had a hard time handling the conditions involved - for instance conditionally using different matplotlib depending on python 2 or 3 or using python3 only for newer paraview and using python2 for older ones. We kept running in spack bugs when trying this.

#11485

Can you suggest a package that does something similar?

@adamjstewart
Copy link
Copy Markdown
Member

This is done by CudaPackage isn't it?

Ah, you're right, completely missed that.

This is what we tried first but we had a hard time handling the conditions involved - for instance conditionally using different matplotlib depending on python 2 or 3 or using python3 only for newer paraview and using python2 for older ones. We kept running in spack bugs when trying this.

I understand. This sounds like a bug in the concretizer that @tgamblin is working on fixing. Let's leave things alone for now and return once a smarter concretizer exists.

@adamjstewart adamjstewart merged commit 210dd59 into spack:develop Oct 2, 2019
tldahlgren pushed a commit to tldahlgren/spack that referenced this pull request Oct 11, 2019
jrmadsen pushed a commit to jrmadsen/spack that referenced this pull request Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants