Skip to content

[WIP] Add package for Jupyter and associated kernels#1297

Closed
jppelteret wants to merge 2 commits intospack:developfrom
jppelteret:features/jupyter-notebook
Closed

[WIP] Add package for Jupyter and associated kernels#1297
jppelteret wants to merge 2 commits intospack:developfrom
jppelteret:features/jupyter-notebook

Conversation

@jppelteret
Copy link
Copy Markdown
Contributor

@jppelteret jppelteret commented Jul 19, 2016 •
edited
Loading

List of packages

Depends on:

Jupyter core

  • Builds on OSX
  • Builds on Linux

Jupyter notebook

  • Builds on OSX
  • Runs on OSX
  • Builds on Linux
  • Runs on Linux

Jupyter console

  • Builds on OSX
  • Runs on OSX
  • Builds on Linux
  • Runs on Linux

Jupyter qt-console

  • Builds on OSX
  • Runs on OSX
  • Builds on Linux
  • Runs on Linux

Available kernels (build/check):

  • iPython (core package)
  • ipywidgets
  • ipyparallel

Additional iPython kernels

Utilities

nbconvert

  • Builds on OSX (issue getting py-pycurl to download required css files)
running css
Failed, trying again with PycURL to avoid outdated SSL.
Failed to download css from https://cdn.jupyter.org/notebook/4.1.0/style/style.min.css: (60, 'SSL certificate problem: unable to get local issuer certificate')
  • Builds on Linux

nbformat

  • Builds on OSX
  • Builds on Linux

Other tasks

  • Dummy package to that collects the Jupyter software suite?
  • Appease the flake master

Note: I have no familiarity with Jupyter as of yet, so I'm just working this out as I go along.
What's going on?

davydden
davydden reviewed Jul 19, 2016
View reviewed changes
var/spack/repos/builtin/packages/py-scipy/package.py Outdated
version('0.15.1', 'be56cd8e60591d6332aac792a5880110')
version('0.15.0', '639112f077f0aeb6d80718dc5019dc7a')

variant('atlas', default=False, description='Compile with ATLAS')
Copy link
Copy Markdown
Member

@davydden davydden Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO should not be a variant.

spack install py-scipy ^atlas

should use it for both blas and lapack. That's when
if 'atlas' in spec: will be triggered.

Copy link
Copy Markdown
Member

@davydden davydden Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's when if 'atlas' in spec: will be triggered.

i think.

Copy link
Copy Markdown
Member

@davydden davydden Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jppelteret you actually forgot to remove the variant in your last commit.

@jppelteret jppelteret force-pushed the features/jupyter-notebook branch from 9756501 to 0f6064b Compare July 19, 2016 12:38
davydden
davydden reviewed Jul 19, 2016
View reviewed changes
var/spack/repos/builtin/packages/py-certifi/package.py Outdated
version('2016.02.28', '5ccfc23bd5e931863f0b01ef3e9d2dbd3bef0e1b')

extends('python')
depends_on('py-setuptools')
Copy link
Copy Markdown
Member

@davydden davydden Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type='build'?

Copy link
Copy Markdown
Contributor Author

@jppelteret jppelteret Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On occasion when I specify depends_on('py-setuptools', type='build) I need to import os for it to work (in my haste I didn't make note of the offending package). However, flake doesn't like this. Is it expected that one needs this import?

Copy link
Copy Markdown
Member

@davydden davydden Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my understanding that this should not be needed. Perhaps @mathstuf could comment on this issue.

Copy link
Copy Markdown
Contributor

@mathstuf mathstuf Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, some more context would be nice.

Copy link
Copy Markdown
Contributor Author

@jppelteret jppelteret Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if I can reproduce the error and will report back. Otherwise I'll just make the suggested changes.

@jppelteret jppelteret force-pushed the features/jupyter-notebook branch from 0f6064b to 7bb2d41 Compare July 19, 2016 14:07
davydden
davydden reviewed Jul 19, 2016
View reviewed changes
var/spack/repos/builtin/packages/py-tornado/package.py Outdated
version('4.0.0', 'c28675e944f364ee96dda3a8d2527a87ed28cfa3')

extends('python')
depends_on('py-setuptools')
Copy link
Copy Markdown
Member

@davydden davydden Jul 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type='build'?

@jppelteret jppelteret force-pushed the features/jupyter-notebook branch from 1b1dd14 to 706b349 Compare August 4, 2016 10:07
This was referenced Aug 4, 2016
Closed
Closed
@jppelteret jppelteret force-pushed the features/jupyter-notebook branch from 3d02215 to 2c15512 Compare August 4, 2016 12:10
@adamjstewart
Copy link
Copy Markdown
Member

adamjstewart commented Aug 4, 2016

For new Python packages, can you use setup_py( instead of python('setup.py',? See #950, #1424, and #1435 for details.

@tgamblin tgamblin added the WIP label Sep 21, 2016
@jppelteret jppelteret closed this Oct 23, 2016
@jppelteret jppelteret mentioned this pull request Nov 12, 2016
Closed
olupton pushed a commit to olupton/spack that referenced this pull request Feb 7, 2022
@matz-e @alexsavulescu
deploy: move *_ROOT var setting to central location (spack#1297)
962c460 
* deploy: move *_ROOT var setting to central location
* compilers shall not export ROOT variables

Co-authored-by: Alexandru Săvulescu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jppelteret @adamjstewart @mathstuf @davydden @tgamblin