Skip to content

Add all the 'generic' architectures that are mentioned in recipes#12958

Merged
tgamblin merged 1 commit intospack:developfrom
alalazo:fixes/add_generic_architecture_mentioned_in_packages
Sep 29, 2019
Merged

Add all the 'generic' architectures that are mentioned in recipes#12958
tgamblin merged 1 commit intospack:developfrom
alalazo:fixes/add_generic_architecture_mentioned_in_packages

Conversation

@alalazo
Copy link
Copy Markdown
Member

@alalazo alalazo commented Sep 26, 2019

LLVM, mesa and other packages check for these generic microarchitectures. One solution is to let Spack know they exist.

@odoublewen

LLVM, mesa and other packages check for these generic
microarchitectures. One solution is to let Spack know they exist.
@alalazo
Copy link
Copy Markdown
Member Author

alalazo commented Sep 26, 2019

@becker33 @tgamblin There might be other solutions to this issue, namely:

  1. Be less strict on requiring that the name we compare against is known to Spack
  2. Remove some of the architectures that are now mentioned in recipes

Let me know if you want to go for 2. as in that case I'll update the PR. For instance, if we don't want sparc I'll remove it from llvm/mesa and from the json file.

@tgamblin tgamblin merged commit 9117dfd into spack:develop Sep 29, 2019
@alalazo alalazo deleted the fixes/add_generic_architecture_mentioned_in_packages branch September 29, 2019 13:05
tldahlgren pushed a commit to tldahlgren/spack that referenced this pull request Oct 11, 2019
…ack#12958)

LLVM, mesa and other packages check for these generic
microarchitectures. One solution is to let Spack know they exist.
jrmadsen pushed a commit to jrmadsen/spack that referenced this pull request Oct 30, 2019
…ack#12958)

LLVM, mesa and other packages check for these generic
microarchitectures. One solution is to let Spack know they exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants