fixing target conversion to string#12914
Merged
tgamblin merged 10 commits intospack:developfrom Sep 25, 2019
Merged
Conversation
tgamblin
previously requested changes
Sep 24, 2019
alalazo
requested changes
Sep 24, 2019
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
LGTM if the check are changed in the form:
if spec.target.family == 'x86_64':
....
Contributor
Author
|
Ok I changed according to the above comments. |
alalazo
requested changes
Sep 25, 2019
Member
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
Using the == operator is needed to check that a microarchitecture is equal to another. The __contains__ semantic is instead of looking for features in the given microarchitecture. See the suggestions given in the first reviews.
alalazo
reviewed
Sep 25, 2019
alalazo
reviewed
Sep 25, 2019
alalazo
reviewed
Sep 25, 2019
alalazo
reviewed
Sep 25, 2019
alalazo
reviewed
Sep 25, 2019
Co-Authored-By: Massimiliano Culpo <[email protected]>
Co-Authored-By: Massimiliano Culpo <[email protected]>
Co-Authored-By: Massimiliano Culpo <[email protected]>
Co-Authored-By: Massimiliano Culpo <[email protected]>
Co-Authored-By: Massimiliano Culpo <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alalazo
approved these changes
Sep 25, 2019
alalazo
dismissed
tgamblin’s stale review
The required changes have been implemented
sethrj
added a commit
to sethrj/spack
that referenced
this pull request
Sep 26, 2019
Since spack#3206, 'spec.architecture.target' returned the microarchitecture target rather than the architecture family. This causes QT 4 to fail to build because it's expecting something like 'x86_64' rather than 'broadwell'. See spack#12914 Erorr message: ``` ==> [2019-09-26-09:37:33.834286] './configure' '-prefix' '/rnsdhpc/code/spack/opt/spack/clang/qt/aguusfi' '-v' '-opensource' '-no-opengl' '-release' '-confirm-license' '-optimized-qmake' '-no-pch' '-no-freetype' '-no-openssl' '-no-sql-db2' '-no-sql-ibase' '-no-sql-oci' '-no-sql-tds' '-no-sql-mysql' '-no-sql-odbc' '-no-sql-psql' '-no-sql-sqlite' '-no-sql-sqlite2' '-shared' '-no-openvg' '-no-nis' '-nomake' 'examples' '-nomake' 'tools' '-no-dbus' '-no-framework' '-fast' '-no-declarative-debug' '-no-gtkstyle' '-no-webkit' '-no-phonon' '-arch' 'broadwell' '-nomake' 'demos' '-cocoa' '-platform' 'unsupported/macx-clang-libc++' '-sdk' '/var/folders/gy/mrg1ffts2h945qj9k29s1l1dvvmbqb/T/s3j/spack-stage/xcode-select/clang/10.0.1-apple/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk' Determining system architecture... (Darwin:18.7.0:x86_64) 'macosx' is supported System architecture: 'macosx' Unknown architecture: "broadwell". Supported architectures: x86[i386] ppc x86_64 ppc64 arm armv6 armv7 ```
sethrj
added a commit
to sethrj/spack
that referenced
this pull request
Sep 26, 2019
Since spack#3206, 'spec.architecture.target' returned the microarchitecture target rather than the architecture family. This causes QT 4 to fail to build because it's expecting something like 'x86_64' rather than 'broadwell'. See spack#12914 Erorr message: ``` ==> [2019-09-26-09:37:33.834286] './configure' '-prefix' '/rnsdhpc/code/spack/opt/spack/clang/qt/aguusfi' '-v' '-opensource' '-no-opengl' '-release' '-confirm-license' '-optimized-qmake' '-no-pch' '-no-freetype' '-no-openssl' '-no-sql-db2' '-no-sql-ibase' '-no-sql-oci' '-no-sql-tds' '-no-sql-mysql' '-no-sql-odbc' '-no-sql-psql' '-no-sql-sqlite' '-no-sql-sqlite2' '-shared' '-no-openvg' '-no-nis' '-nomake' 'examples' '-nomake' 'tools' '-no-dbus' '-no-framework' '-fast' '-no-declarative-debug' '-no-gtkstyle' '-no-webkit' '-no-phonon' '-arch' 'broadwell' '-nomake' 'demos' '-cocoa' '-platform' 'unsupported/macx-clang-libc++' '-sdk' '/var/folders/gy/mrg1ffts2h945qj9k29s1l1dvvmbqb/T/s3j/spack-stage/xcode-select/clang/10.0.1-apple/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk' Determining system architecture... (Darwin:18.7.0:x86_64) 'macosx' is supported System architecture: 'macosx' Unknown architecture: "broadwell". Supported architectures: x86[i386] ppc x86_64 ppc64 arm armv6 armv7 ```
Contributor
|
Edit: for the record, the side-effect issue reported below will be addressed by #12958 Since this merge, when trying to install mesa, I'm now seeing: Here's the traceback: Here's the spec: |
Member
|
@odoublewen Working on a fix right now. |
Contributor
|
FYI: mesa install error is resolved for me. |
tldahlgren
pushed a commit
to tldahlgren/spack
that referenced
this pull request
Oct 11, 2019
* llvm: fixed issues with syntax and formatting * use spec.architecture.target.family * use spec.target instead of spec.architecture.target * mesa: use == instead of __contains__
jrmadsen
pushed a commit
to jrmadsen/spack
that referenced
this pull request
Oct 30, 2019
* llvm: fixed issues with syntax and formatting * use spec.architecture.target.family * use spec.target instead of spec.architecture.target * mesa: use == instead of __contains__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12931.
I suppose the recent introduction of a Target object broke a number of packages that assumed
spec.architecture.targetto be a string. Here is a fix for the llvm and mesa packages.