Skip to content

blis: fix darwin install name#12869

Merged
adamjstewart merged 1 commit intospack:developfrom
adamjstewart:fixes/blis
Sep 19, 2019
Merged

blis: fix darwin install name#12869
adamjstewart merged 1 commit intospack:developfrom
adamjstewart:fixes/blis

Conversation

@adamjstewart
Copy link
Copy Markdown
Member

@adamjstewart adamjstewart commented Sep 18, 2019

Fixes numpy/numpy#14180

Before

$ otool -L /Users/Adam/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.1-apple/blis-0.6.0-rufmzbffyfzqafiolixs4ztwdwz73adj/lib/libblis.dylib 
/Users/Adam/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.1-apple/blis-0.6.0-rufmzbffyfzqafiolixs4ztwdwz73adj/lib/libblis.dylib:
	libblis.2.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.250.1)

After

$ otool -L /Users/Adam/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.1-apple/blis-0.6.0-v7dirtoptoe5d3vaxjb223mr6to6y3sb/lib/libblis.dylib 
/Users/Adam/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.1-apple/blis-0.6.0-v7dirtoptoe5d3vaxjb223mr6to6y3sb/lib/libblis.dylib:
	/Users/Adam/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.1-apple/blis-0.6.0-v7dirtoptoe5d3vaxjb223mr6to6y3sb/lib/libblis.2.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.250.1)

With this PR, I'm finally able to build py-numpy +blas~lapack ^blis+cblas! All numpy unit tests pass, and library is linked correctly:

$ otool -L /Users/Adam/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.1-apple/py-numpy-1.17.2-pi2y57jtkngucg44dn2w5m3rgtkd2r66/lib/python3.7/site-packages/numpy/core/_multiarray_umath.cpython-37m-darwin.so 
/Users/Adam/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.1-apple/py-numpy-1.17.2-pi2y57jtkngucg44dn2w5m3rgtkd2r66/lib/python3.7/site-packages/numpy/core/_multiarray_umath.cpython-37m-darwin.so:
	/Users/Adam/spack/opt/spack/darwin-mojave-x86_64/clang-10.0.1-apple/blis-0.6.0-v7dirtoptoe5d3vaxjb223mr6to6y3sb/lib/libblis.2.dylib (compatibility version 0.0.0, current version 0.0.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.250.1)

Since --enable-cblas is required to build py-numpy, I opted to switch it to default=True in the blis package.

@s-sajid-ali

This was referenced Sep 18, 2019
Merged
Closed
@adamjstewart adamjstewart merged commit cbbd384 into spack:develop Sep 19, 2019
@adamjstewart adamjstewart deleted the fixes/blis branch September 19, 2019 03:46
tldahlgren pushed a commit to tldahlgren/spack that referenced this pull request Oct 11, 2019
@adamjstewart @tldahlgren
blis: fix darwin install name (spack#12869)
0791f77
jrmadsen pushed a commit to jrmadsen/spack that referenced this pull request Oct 30, 2019
@adamjstewart @jrmadsen
blis: fix darwin install name (spack#12869)
bf3482c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

macOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problems building numpy with BLIS

1 participant

@adamjstewart