Skip to content

netcdf: link to MPI#128

Merged
tgamblin merged 1 commit intospack:developfrom
mathstuf:netcdf-new-linker-mpi
Oct 21, 2015
Merged

netcdf: link to MPI#128
tgamblin merged 1 commit intospack:developfrom
mathstuf:netcdf-new-linker-mpi

Conversation

@mathstuf
Copy link
Copy Markdown
Contributor

Newer GNU linker refuses to use transitive linking; if netcdf calls
MPI_Allreduce, it must link the providing library directly.

Also switched to CMake because I don't know autoconf well enough to know
how to put MPI stuff into it.

Newer GNU linker refuses to use transitive linking; if netcdf calls
MPI_Allreduce, it must link the providing library directly.

Also switched to CMake because I don't know autoconf well enough to know
how to put MPI stuff into it.
@aashish24
Copy link
Copy Markdown

🎉

@mathstuf
Copy link
Copy Markdown
Contributor Author

The initial netcdf release with CMake support is 4.2.1.

@tgamblin
Copy link
Copy Markdown
Member

@mathstuf: Can the MPI patch be done with a filter_file or similar call? We've found that with Spack (where you have to support multiple versions in the package) the patches aren't as robust as adding a patch() function and manually modifying the files. The current version's fine -- I can merge it, but feel free to add that as a separate request.

tgamblin added a commit that referenced this pull request Oct 21, 2015
@tgamblin tgamblin merged commit c8f0148 into spack:develop Oct 21, 2015
@mathstuf mathstuf deleted the netcdf-new-linker-mpi branch October 21, 2015 20:46
@mathstuf
Copy link
Copy Markdown
Contributor Author

For something like this, I think a patch is better. Adding lines with no context will only mean that we add duplicate lines or add it to the wrong place if things change between versions.

@tgamblin
Copy link
Copy Markdown
Member

Will a patch still apply if the context line numbers don't match? I seem to recall there being a threshold, so maybe it's ok. I think it's fine to leave it as a patch for now.

@mathstuf
Copy link
Copy Markdown
Contributor Author

There's a "fuzz" factor it uses to try and "wiggle" the code in by removing context lines. By default, it is 2.

matz-e pushed a commit to matz-e/spack that referenced this pull request Nov 5, 2018
* Refactoring neurodamus building for python support
* Several neurodamus improvements
 - syn2 variant renamed to syntool, and made default
 - exporting location of NEURODAMUS_PYTHON, not PYDAMUS
 - more refactoring
matz-e pushed a commit to matz-e/spack that referenced this pull request Jan 28, 2019
* Refactoring neurodamus building for python support
* Several neurodamus improvements
 - syn2 variant renamed to syntool, and made default
 - exporting location of NEURODAMUS_PYTHON, not PYDAMUS
 - more refactoring
climbfuji added a commit to climbfuji/spack that referenced this pull request Jul 14, 2022
…ild_type_prevent_overlinking

Prevent overlinking against MPI libraries in ECMWF software and add support for different build types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants