Merged
Conversation
5 tasks
Member
@adamjstewart do you think that should be addressed before merging? Does it seem to be an issue with the unit tests or with Spack? |
Member
Author
|
@scheibelp I don't care enough to get the unit tests to pass. I don't think it's a Spack issue. Since it's a first pass on a new package, I think it's fine that the tests don't pass as long as the package installs. If someone runs into an issue, the unit tests would be the first place to check though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs fine, although the unit tests don't pass.
Depends on #12160