Add SIPPackage base class#12157
Merged
adamjstewart merged 1 commit intospack:developfrom Jul 30, 2019
Merged
Conversation
This was referenced Jul 27, 2019
dev-zero
pushed a commit
to dev-zero/spack
that referenced
this pull request
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new base class for the SIP build system. SIP is very similar to QMake in the sense that it contains a
configure.pyscript that generates.profiles, followed by the usualqmake,make,make install. SIP is also similar to Python's build system in the sense that it is designed to install Python bindings for a C/C++ library like Qt. SIP was originally designed for PyQt and PyKDE but can be used as the build system for any Python/C/C++ project.SIPPackagebase classspack createsupportspack configuresupportspack buildsupportLet me know if there's anything else I'm forgetting.
With this branch,
py-pyqt5successfully installs and passes the import tests. I was unable to testpy-pyqt4due to #12139.