Updated prefix in cmake_args for Plasma#12103
Conversation
| options.extend([ | ||
| "-DCMAKE_INSTALL_PREFIX=%s" % prefix, | ||
| "-DCMAKE_INSTALL_NAME_DIR:PATH=%s/lib" % prefix, | ||
| "-DCMAKE_INSTALL_PREFIX=%s" % self.prefix, |
There was a problem hiding this comment.
This is already set in the _std_args of CMakePackage so you don't actually need it.
There was a problem hiding this comment.
Even during the module creation? If that's the case I'm honestly not sure what I changed to get it to work then.
There was a problem hiding this comment.
I'm not sure why either of these lines are present in the file, but you're correct that just using prefix without the self. is a bug.
There was a problem hiding this comment.
In that case should I close this and open up an issue? I'm not sure I have any other examples where I've experienced this.
There was a problem hiding this comment.
I copied it from version 17 when PLASMA was installed with Makefile. I removed it and tested on x86 and POWER with OpenBLAS and Netlib-LAPACK. It is not necessary.
3 participants
Plasma installs correctly (in this instance as part of the xSDK but I've also installed individually) but I'm experiencing the following error when attempting to generate module files.
The fix appears to be using
self.prefixinstead of justprefixin thecmake_args(self)method. But if this is the wrong approach please let me know. Other posts relating to the "is not defined" error message did not help correct it.@luszczek hope you don't mind I tag you on this PR since your marked as the maintainer.