Fix condition to enable mpi4py.#11707
Merged
chuckatkins merged 5 commits intospack:developfrom Jun 17, 2019
Merged
Conversation
danlipsa
force-pushed
the
paraview_mpi4py
branch
2 times, most recently
from
7027da8 to
7bf0175
Compare
Contributor
Author
|
@chuckatkins @jrood-nrel Please review. |
Member
|
This looks good. I also verified that if I used |
chuckatkins
suggested changes
Jun 14, 2019
chuckatkins
left a comment
chuckatkins
left a comment
There was a problem hiding this comment.
See comments inline. I think the catalyst package also needs the mpi4py option so it would be good to have both packages use the same block of code to set python and mpi4py options.
danlipsa
force-pushed
the
paraview_mpi4py
branch
from
7bf0175 to
b7350f0
Compare
Contributor
Author
|
@chuckatkins How is it now? |
chuckatkins
suggested changes
Jun 15, 2019
chuckatkins
left a comment
chuckatkins
left a comment
There was a problem hiding this comment.
It looks good. It's helpful for the two packages to have the same logic since they use the same source. There's a duplicate PARAVIEW_ENABLE_PYTHON leftover in catalyst though. Otherwise it's good to go.
chuckatkins
approved these changes
Jun 17, 2019
carsonwoods
pushed a commit
to carsonwoods/spack
that referenced
this pull request
Jun 27, 2019
* Fix condition to enable mpi4py. * flake8 * Catalyst as paraview for mpi4py. * Catalyst needs numpy and mpi4py. * Remove leftover enable python.
dev-zero
pushed a commit
to dev-zero/spack
that referenced
this pull request
Aug 13, 2019
* Fix condition to enable mpi4py. * flake8 * Catalyst as paraview for mpi4py. * Catalyst needs numpy and mpi4py. * Remove leftover enable python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.