Added a function that concretizes specs together#11158
Merged
becker33 merged 9 commits intospack:developfrom May 3, 2019
Merged
Added a function that concretizes specs together#11158becker33 merged 9 commits intospack:developfrom
becker33 merged 9 commits intospack:developfrom
Conversation
alalazo
requested review from
adamjstewart,
becker33,
davydden,
scheibelp and
tgamblin
This was referenced Apr 10, 2019
becker33
requested changes
Apr 10, 2019
Member
Author
|
@becker33 Ready for another review |
Member
Author
This makes the specs different objects and removes any reference to the fake root package that is needed currently for concretization.
alalazo
force-pushed
the
features/concretize_specs_together
branch
from
7b65478 to
de551bc
Compare
becker33
reviewed
Apr 21, 2019
becker33
approved these changes
Apr 21, 2019
becker33
requested changes
Apr 21, 2019
Member
becker33
left a comment
becker33
left a comment
There was a problem hiding this comment.
I'm a little concerned that the tests are hard to read. Posted an idea for a rewrite of the test. It could also be refactored further to keep the invariant as a function to check with.
becker33
requested changes
Apr 22, 2019
Closed
Member
Author
|
@becker33 ping |
becker33
approved these changes
May 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers to #9902
Refers to #11095
This PR adds a function that concretizes specs together or fails trying to do so.
Rationale
In many contexts (e.g. when using Spack environments to develop software or sometimes when deploying applications in a container) there could be the need to concretize specs together - meaning there will be a single configuration for each package in the DAG. This PR adds a function that permits to do just that:
The function comes with unit tests and can be used later to solve issues like #9902
Description
The implementation of this functionality relies on the current state of the concretizer and repository modules in Spack. This involves:
Being factored within a single function, it shouldn't be difficult to adapt this once the new concretizer will be in place. If need be error handling (in particular user messages) can be improved either in this PR or in a follow up.