Revert to manual flag enabling, due to RegCM bug in configure.#10863
Merged
adamjstewart merged 1 commit intospack:developfrom Mar 13, 2019
Merged
Revert to manual flag enabling, due to RegCM bug in configure.#10863adamjstewart merged 1 commit intospack:developfrom
adamjstewart merged 1 commit intospack:developfrom
Conversation
The configure of RegCM treats --disable-FEATURE as --enable-FEATURE, so we cannot use enable_or_disable.
adamjstewart
approved these changes
Mar 13, 2019
Member
This is a long-standing issue. See #8639 for more discussion. For now, you'll have to manually configure your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configure of RegCM treats --disable-FEATURE as --enable-FEATURE,
so we cannot use enable_or_disable.
I'd also like to fix issue #10163; I tried specifying:
depends_on('mpi', type=('build', 'link', 'run'))but the openmpi bin wasn't added to the PATH in the module created; the following is the line with PATH from the module:
prepend-path PATH /.../intel/18.0.3/regcm/4.7.1-SVN6916-cosiybixa6r2korik6vaajsq4xfxhjmv/bin.Shouldn't
'run'include the dependency in the PATH? Is it a bug?https://spack.readthedocs.io/en/latest/packaging_guide.html?highlight=run#dependency-types