netcdf: Eliminate spurious dependence on hdf5+mpi#10788
Merged
scheibelp merged 1 commit intospack:developfrom Mar 7, 2019
Merged
netcdf: Eliminate spurious dependence on hdf5+mpi#10788scheibelp merged 1 commit intospack:developfrom
scheibelp merged 1 commit intospack:developfrom
Conversation
Without the change in this PR, NetCDF will always depend on a `+mpi` variant of hdf5. The best I can determine is that the simple specification of `depends_on('[email protected]:+hl')` will always select the `+mpi` hdf5 variant whether `+mpi` or `~mpi` were specified for NetCDF:
```
ews00321:spack(develop)> spack spec netcdf+mpi
Input spec
--------------------------------
netcdf+mpi
Concretized
--------------------------------
[email protected]%[email protected]~dap~hdf4 maxdims=1024 maxvars=8192 +mpi~parallel-netcdf+pic+shared arch=linux-rhel7-x86_64
^[email protected]%[email protected]~cxx~debug~fortran+hl+mpi+pic+shared~szip~threadsafe arch=linux-rhel7-x86_64
^[email protected]%[email protected]~cuda+cxx_exceptions fabrics=auto ~java~legacylaunchers~memchecker~pmi schedulers=auto ~sqlite3~thread_multiple+vt arch=linux-rhel7-x86_64
^[email protected]%[email protected]+optimize+pic+shared arch=linux-rhel7-x86_64
^[email protected]%[email protected] patches=3877ab548f88597ab2327a2230ee048d2d07ace1062efe81fc92e91b7f39cd00,c0a408fbffb7255fcc75e26bd8edab116fc81d216bfd18b473668b7739a4158e,fc9b61654a3ba1a8d6cd78ce087e7c96366c290bc8d2c299f09828d793b853c8 +sigsegv arch=linux-rhel7-x86_64
ews00321:spack(develop)> spack spec netcdf~mpi
Input spec
--------------------------------
netcdf~mpi
Concretized
--------------------------------
[email protected]%[email protected]~dap~hdf4 maxdims=1024 maxvars=8192 ~mpi~parallel-netcdf+pic+shared arch=linux-rhel7-x86_64
^[email protected]%[email protected]~cxx~debug~fortran+hl+mpi+pic+shared~szip~threadsafe arch=linux-rhel7-x86_64
^[email protected]%[email protected]~cuda+cxx_exceptions fabrics=auto ~java~legacylaunchers~memchecker~pmi schedulers=auto ~sqlite3~thread_multiple+vt arch=linux-rhel7-x86_64
^[email protected]%[email protected]+optimize+pic+shared arch=linux-rhel7-x86_64
^[email protected]%[email protected] patches=3877ab548f88597ab2327a2230ee048d2d07ace1062efe81fc92e91b7f39cd00,c0a408fbffb7255fcc75e26bd8edab116fc81d216bfd18b473668b7739a4158e,fc9b61654a3ba1a8d6cd78ce087e7c96366c290bc8d2c299f09828d793b853c8 +sigsegv arch=linux-rhel7-x86_64
```
With the change in this PR, the `~mpi` variant now shows:
```
ews00321:spack(develop)> spack spec netcdf~mpi
Input spec
--------------------------------
netcdf~mpi
Concretized
--------------------------------
[email protected]%[email protected]~dap~hdf4 maxdims=1024 maxvars=8192 ~mpi~parallel-netcdf+pic+shared arch=linux-rhel7-x86_64
^[email protected]%[email protected]~cxx~debug~fortran+hl~mpi+pic+shared~szip~threadsafe arch=linux-rhel7-x86_64
^[email protected]%[email protected]+optimize+pic+shared arch=linux-rhel7-x86_64
^[email protected]%[email protected] patches=3877ab548f88597ab2327a2230ee048d2d07ace1062efe81fc92e91b7f39cd00,c0a408fbffb7255fcc75e26bd8edab116fc81d216bfd18b473668b7739a4158e,fc9b61654a3ba1a8d6cd78ce087e7c96366c290bc8d2c299f09828d793b853c8 +sigsegv arch=linux-rhel7-x86_64
```
which does not have the `openmpi` dependency and is correct.
Member
|
You may have expected not to need to specify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change in this PR, NetCDF will always depend on a
+mpivariant of hdf5. The best I can determine is that the simple specification ofdepends_on('[email protected]:+hl')will always select the+mpihdf5 variant whether+mpior~mpiwere specified for NetCDF:With the change in this PR, the
~mpivariant now shows:which does not have the
openmpidependency and is correct.