WIP: Release workflow improvements#10771
Closed
scottwittenburg wants to merge 4 commits intospack:developfrom
Closed
WIP: Release workflow improvements#10771scottwittenburg wants to merge 4 commits intospack:developfrom
scottwittenburg wants to merge 4 commits intospack:developfrom
Conversation
972c980 to
182e4f0
Compare
894823e to
64cd4a6
Compare
cdff4d6 to
27c5fa5
Compare
cca3277 to
0d01417
Compare
3f3d815 to
347e4e2
Compare
c0d8a20 to
85c1836
Compare
85c1836 to
a3736a4
Compare
Contributor
Author
|
Closing in favor of #11612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds new fields to the
release.yamlfile, fixes an issue where thecdashfield from that file was ignored, and updates the release workflow to make use of two repositories.New fields are added to the
release.yamlfile:ci-exceptandci-onlyallows lists of strings which will be added to each job to control conditions under which the jobs will or will not run. The values provided in these two new fields are expected to be compatible with the strings allowed in the only/except fields of jobs as described in the gitlab-ci documentation. Another new field added torelease.yamlisrelease-tag, which will be used in two ways: added to the job name, and used as the build group within CDash.This change also fixes the issue where the 'cdash' field of the
release.yamlwas ignored and instead expected to be provided as argument to therelease-jobscommand. That argument has been removed in favor of the field from the yaml file. Also, since we are not currently reporting to more than one cdash site for a release, the 'cdash' field has been changed from a list to a single entry, but where the baseurl and project can be configured separately.Additionally, this change adds support for a 2-repo approach to the workflow release. In this approach, a first repository (in the cloud system, the gitlab set up to mirror spack on github) is used to generate the
.gitlab-ci.yaml, and push it as a commit to a secondary repository, where the build jobs will actually be run. In the current incarnation, the first repo CI executes a single job which:GETrequests to the microservice to generate the jobs (.gitlab-ci.yaml)release-tagin therelease.yaml.gitlab-ci.ymland pushes it to the next CI repo where the packages are actually built