doxygen: Make build work in Python3 environment#10589
Merged
alalazo merged 2 commits intospack:developfrom Nov 21, 2019
Merged
Conversation
healther
approved these changes
Feb 15, 2019
healther
approved these changes
Feb 15, 2019
Contributor
healther
left a comment
healther
left a comment
There was a problem hiding this comment.
btw should we add python@2:2.8 as a build dependency in a commented fashion, like in node-js? A future concretiser should be able to deal with that and system python's will start becoming python3s in the future?
A look at the Python code in Doxygen reveals it should work just fine in Python2 or Python3; comments in the Python code even say so. The problem before worked as follows... Python was not declared as a Spack dependency. When Doxygen's CMake ran find(PythonInterp), it found the system's Python. But for whatever reason, the user had `PYTHONPATH` set (maybe because they needed to build `--dirty`). This cause an untenable situation, in which Python2 was run with Python3 libraries. The solution to this problem is to include Python as a dependency. It should work find with Python2 or Python3.
Member
Author
|
@healther Your question prompted a re-examination of the issue, and ultimately a better/simpler solution. |
healther
approved these changes
Feb 19, 2019
alalazo
approved these changes
Nov 21, 2019
|
|
||
| depends_on("[email protected]:", type='build') | ||
| depends_on("python", type='build') # 2 or 3 OK; used in CMake build | ||
| depends_on("libiconv") |
Member
There was a problem hiding this comment.
michaelkuhn
added a commit
to michaelkuhn/spack
that referenced
this pull request
Dec 11, 2019
PR spack#10589 introduced a libiconv dependency to doxygen. This causes problems on Linux systems, since the iconv symbols are included in libc, which causes CMake to use the external header but not the external library. Work around this by always using the external libiconv.
adamjstewart
pushed a commit
that referenced
this pull request
Dec 11, 2019
PR #10589 introduced a libiconv dependency to doxygen. This causes problems on Linux systems, since the iconv symbols are included in libc, which causes CMake to use the external header but not the external library. Work around this by always using the external libiconv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.